Fix README Handle path #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main fix here is to add a trailing "/" to the `Handle` path -- without the trailing slash, `Handle` only handles the exact path "/assets", not "/assets/*". The `StripPrefix` path doesn't strictly need the trailing slash, but it's less confusing if they match. Also fix the `<script>` tag so it actually works (though I realize that's not the point of this example).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this package! I was surprised
embeddidn't do something like this by default, and then I found the issue related to that that was closed. In any case, this PR just fixes a typo in thehttp.Handlepath in the example in the README.The main fix here is to add a trailing "/" to the
Handlepath -- without the trailing slash,Handleonly handles the exact path "/assets", not "/assets/*".The
StripPrefixpath doesn't strictly need the trailing slash, but it's less confusing if they match.Also fix the
<script>tag so it actually works (though I realize that's not the point of this example).